gh-142999: Make test_venv use sysconfig._get_implementation().lower() instead of hardcoding "python"#143000
Open
youknowone wants to merge 1 commit intopython:mainfrom
Open
gh-142999: Make test_venv use sysconfig._get_implementation().lower() instead of hardcoding "python"#143000youknowone wants to merge 1 commit intopython:mainfrom
youknowone wants to merge 1 commit intopython:mainfrom
Conversation
instead of hard-coded "python"
gvanrossum
changed the title
vsajip
previously approved these changes
Dec 24, 2025
Contributor
Author
|
@vsajip I am not sure this is the correct fix. #142999 (comment) |
vsajip
dismissed
their stale review
Further changes are apparently being proposed.
Contributor
Author
|
@vsajip could you advise what will be the best fix? Does EnvBuilder look good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of hard-coded "python"
I tried to use
EnvBuilder._venv_pathorsysconfig.get_path('purelib', scheme='venv'), but that complicatesIMPL_NAMEinitialization because they returns abstract path. Please tell me if that's better.